Marked rebase-snap as deprecated#4209
Merged
ShadowCurse merged 1 commit intofirecracker-microvm:mainfrom Oct 31, 2023
Merged
Conversation
ShadowCurse
force-pushed
the
deprecate_snap_rebase
branch
3 times, most recently
from
752a731 to
ea735ea
Compare
kalyazin
previously approved these changes
Oct 31, 2023
ShadowCurse
added
Status: Awaiting review
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4209 +/- ##
==========================================
- Coverage 82.93% 82.92% -0.02%
==========================================
Files 221 221
Lines 28231 28235 +4
==========================================
Hits 23414 23414
- Misses 4817 4821 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
bchalios
reviewed
Oct 31, 2023
ShadowCurse
force-pushed
the
deprecate_snap_rebase
branch
from
ea735ea to
0b96e0f
Compare
ShadowCurse
force-pushed
the
deprecate_snap_rebase
branch
from
0b96e0f to
1b2d393
Compare
bchalios
previously approved these changes
Oct 31, 2023
ShadowCurse
force-pushed
the
deprecate_snap_rebase
branch
from
1b2d393 to
612d94b
Compare
zulinx86
previously approved these changes
Oct 31, 2023
Marked `rebase-snap` as deprecated in favour of `snapshot-editor` Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
deprecate_snap_rebase
branch
from
612d94b to
c242b2c
Compare
bchalios
approved these changes
Oct 31, 2023
kalyazin
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Marked
rebase-snapas deprecated in favour ofsnapshot-editorReason
We have
snapshot-editorwhich is a newer tool with more options.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.